Skip to content

Improve Mixins page #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Improve Mixins page #285

merged 2 commits into from
Sep 20, 2020

Conversation

CyberAP
Copy link
Contributor

@CyberAP CyberAP commented Jul 20, 2020

State that:

  1. Mixins are a simple way to reuse component logic, rather than a flexible way to do it. The term flexible goes into conflict with the last chapter of the page, which describes that mixins are in fact inflexible.
  2. Add a section title for Precautions.

Note

Thanks for your interest in submitting a PR! At this time, because the docs are in beta, the team is currently in the midst of changes and we are not ready for additional contributions yet.

To bring your issue to the team's attention though, we would recommend creating an issue and we'll get to it when we can.

Thanks for your understanding!

State that:

1. Mixins are a __simple__ way to reuse component logic, rather than a flexible way to do it. The term __flexible__ goes into conflict with the last chapter of the page, which describes that mixins are in fact inflexible.
2. Add a section title for Precautions.
Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Overall, agreed on the sentiment for the PR, just a small note on what to change.

Co-authored-by: Stanislav Lashmanov <stasvarenkin@gmail.com>
@NataliaTepluhina NataliaTepluhina merged commit 1a80da0 into vuejs:master Sep 20, 2020
nick-lai pushed a commit to nick-lai/docs-next that referenced this pull request Dec 2, 2020
* Improve Mixins page

State that:

1. Mixins are a __simple__ way to reuse component logic, rather than a flexible way to do it. The term __flexible__ goes into conflict with the last chapter of the page, which describes that mixins are in fact inflexible.
2. Add a section title for Precautions.

* Update src/guide/mixins.md

Co-authored-by: Stanislav Lashmanov <stasvarenkin@gmail.com>

Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants